Skip to content

chore: expose a public function to get connect method order with appkit instance #8163

chore: expose a public function to get connect method order with appkit instance

chore: expose a public function to get connect method order with appkit instance #8163

Triggered via pull request December 17, 2024 09:57
Status Success
Total duration 13m 44s
Artifacts

pr_checks.yml

on: pull_request
Matrix: code_style
Matrix: ui-test / Playwright Tests
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 21 warnings
tests/controllers/PublicStateController.test.ts > PublicStateController > should have valid default state: packages/core/tests/controllers/PublicStateController.test.ts#L7
AssertionError: expected { loading: false, open: false, …(3) } to deeply equal { loading: false, open: false, …(1) } - Expected + Received Object { + "activeChain": undefined, + "initialized": false, "loading": false, "open": false, "selectedNetworkId": undefined, } ❯ tests/controllers/PublicStateController.test.ts:7:41
tests/controllers/PublicStateController.test.ts > PublicStateController > should update state correctly on set(): packages/core/tests/controllers/PublicStateController.test.ts#L16
AssertionError: expected { loading: false, open: true, …(3) } to deeply equal { loading: false, open: true, …(1) } - Expected + Received Object { + "activeChain": undefined, + "initialized": false, "loading": false, "open": true, "selectedNetworkId": undefined, } ❯ tests/controllers/PublicStateController.test.ts:16:41
test
Process completed with exit code 1.
code_style (danger)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
code_style (prettier)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
code_style (typecheck)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
code_style (lint)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
code_style (lint): packages/common/src/utils/InputUtil.ts#L29
Variable name `controlPressed` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/common/src/utils/InputUtil.ts#L32
Variable name `selectAll` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/common/src/utils/InputUtil.ts#L33
Variable name `copyKey` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/common/src/utils/InputUtil.ts#L34
Variable name `pasteKey` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/common/src/utils/InputUtil.ts#L35
Variable name `cutKey` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/wallet-button/src/scaffold-ui/appkit-wallet-button/index.ts#L90
Variable name `walletConnect` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/wallet-button/src/scaffold-ui/appkit-wallet-button/index.ts#L92
Variable name `loading` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/wallet-button/src/utils/ConnectorUtil.ts#L78
Variable name `connectingSocial` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/adapters/ethers/src/client.ts#L259
Variable name `injectedConnector` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/adapters/ethers5/src/client.ts#L260
Variable name `injectedConnector` must have one of the following prefixes: is, has, can, should, will, did
test
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
code_style (build:sample-apps)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
ui-test / Playwright Tests (1, 5)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
ui-test / Playwright Tests (5, 5)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
ui-test / Playwright Tests (3, 5)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
ui-test / Playwright Tests (2, 5)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
ui-test / Playwright Tests (4, 5)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/