Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(next-auth-url): add missing env var NEXTAUTH_URL #1591

Merged
merged 4 commits into from
Jan 8, 2024
Merged

chore(next-auth-url): add missing env var NEXTAUTH_URL #1591

merged 4 commits into from
Jan 8, 2024

Conversation

Cali93
Copy link
Collaborator

@Cali93 Cali93 commented Dec 20, 2023

Breaking Changes

NEXTAUTH_URL is required to run SIWE locally.

Changes

  • feat:
  • fix:
  • chore(next-auth-url): add missing env var NEXTAUTH_URL

@vercel Vercel
Copy link

vercel bot commented Dec 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Jan 8, 2024 6:56am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jan 8, 2024 6:56am
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Jan 8, 2024 6:56am
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Jan 8, 2024 6:56am

@Cali93 Cali93 requested review from svenvoskamp and xzilja December 20, 2023 09:13
xzilja
xzilja reviewed Dec 20, 2023
View reviewed changes
Copy link
Contributor

@xzilja xzilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like package-lock is updated, but there are no package.json changes. Is this expected?

xzilja
xzilja reviewed Dec 20, 2023
View reviewed changes
Copy link
Contributor

@xzilja xzilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also want to update dangerjs rule to exclude checking for localhost in these files or, simply remove localhost as default value in favor of "" <- this might be better to not polute dangerfile

xzilja
xzilja previously approved these changes Jan 1, 2024
View reviewed changes
@Cali93 Cali93 force-pushed the chore/missing-env-var branch from 05d9efe to 92704ba Compare January 2, 2024 08:11
@Cali93
Copy link
Collaborator Author

Cali93 commented Jan 2, 2024 •
edited
Loading

Looks like package-lock is updated, but there are no package.json changes. Is this expected?

I just pulled V3 and npm run clean; npm install and I still have a diff for package-lock.json 👀

@xzilja xzilja merged commit eb9c2e8 into V3 Jan 8, 2024
11 of 12 checks passed
@xzilja xzilja deleted the chore/missing-env-var branch January 8, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzilja xzilja xzilja left review comments

@svenvoskamp svenvoskamp Awaiting requested review from svenvoskamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cali93 @xzilja