Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(get-nonce-optional-address): add optional address param to getNonce #2046

Merged
merged 2 commits into from
Mar 18, 2024
Merged

chore(get-nonce-optional-address): add optional address param to getNonce #2046

merged 2 commits into from
Mar 18, 2024

Conversation

Cali93
Copy link
Collaborator

@Cali93 Cali93 commented Mar 13, 2024

Breaking Changes

N/A

Changes

  • chore: adds optional address argument to the getNonce function

Associated Issues

Request from Cyberconnect

@vercel Vercel
Copy link

vercel bot commented Mar 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3modal-demo ❌ Failed (Inspect) Mar 18, 2024 10:05am
web3modal-gallery ✅ Ready (Inspect) Visit Preview Mar 18, 2024 10:05am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Mar 18, 2024 10:05am
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Mar 18, 2024 10:05am
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Mar 18, 2024 10:05am

@Cali93 Cali93 requested review from glitch-txs and arein March 13, 2024 08:59
glitch-txs
glitch-txs approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@glitch-txs glitch-txs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arein
arein approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests?

@Cali93
Copy link
Collaborator Author

Cali93 commented Mar 13, 2024 •
edited
Loading

Tests?

It is a non breaking change.
Adding E2E tests for SIWE should be done in a separate PR.

@Cali93 Cali93 merged commit 9887e9f into V4 Mar 18, 2024
14 of 15 checks passed
@Cali93 Cali93 deleted the chore/nonce-optional-address branch March 18, 2024 15:38
@tomiir tomiir mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glitch-txs glitch-txs glitch-txs approved these changes

@arein arein arein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cali93 @arein @glitch-txs