chore: remove "upgrade to smart account" screen #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 8b92ea1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Coverage Report for Coverage
File Coverage
|
||||||||||||||||||||||||||||||||||||||
magiziz
changed the title
magiziz
commented
Dec 4, 2024
Comment on lines
+14
to
+18
| vi.spyOn(CoreHelperUtil, 'isMobile').mockReturnValue(false) | ||
| vi.spyOn(AccountController, 'state', 'get').mockReturnValue({ | ||
| ...AccountController.state, | ||
| address: undefined | ||
| }) |
There was a problem hiding this comment.
There were some issues with valtio proxy states and web components when trying to use vi.mock('@reown/appkit-core', ()=> ...), instead i used vi.spyOn which works for now 🙏
tomiir
reviewed
Dec 4, 2024
| @@ -265,10 +241,6 @@ export class W3mAccountWalletFeaturesWidget extends LitElement { | |||
| }) | |||
| RouterController.push('WalletSend') | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
given we are removing access to the route, we shuold remove all unnecessary views and specific components to reduce bundle
magiziz
changed the title
magiziz
force-pushed
the
chore/remove-smart-account-tag
branch
from
873c275 to
b0af6d9
Compare
tomiir
approved these changes
Dec 4, 2024
magiziz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Blocked by this PR #3372
Removed "active your account" tag
Type of change
Associated Issues
For Linear issues: Closes APKT-1183
Checklist