Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use chain default rpc url on wallet_addEthereumChain #3390

Merged
merged 9 commits into from
Dec 5, 2024

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Dec 4, 2024

Description

  • Preserves chain default RPC url
  • Uses chain's default RPC url when calling wallet_addEthereumChain on Ethers and UP
  • Wagmi does not seem to recognize this rpc overriding on connect or switching networks. Will check with their team

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

Closes
https://linear.app/reown/issue/APKT-1415/[bug]-switchnetwork-exposes-project-id-and-stores-it-in-user-wallet

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: 7efb1b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 9:16pm
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 9:16pm
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 9:16pm
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 9:16pm

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 47.8% 12303 / 25738
🔵 Statements 47.8% 12303 / 25738
🔵 Functions 34.29% 833 / 2429
🔵 Branches 76.68% 1312 / 1711
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/adapters/ethers/src/client.ts 46.15% 51.78% 54.54% 46.15% 39-97, 113-114, 145-146, 166-189, 192-202, 215-251, 256-257, 264-281, 286-303, 306-327, 330-335, 345-346, 353-357, 380-387, 390-417, 421-422, 435-436, 438, 460-461, 465, 479, 490-492, 495-500, 503-507, 521-527, 549-551, 556-557, 559-564, 574-592, 598-599, 603-608, 617-618, 629-630
packages/adapters/wagmi/src/connectors/UniversalConnector.ts 5.86% 100% 100% 5.86% 75-438
packages/appkit-utils/src/CaipNetworkUtil.ts 86.56% 82.35% 88.88% 86.56% 72-89, 119, 185-186
packages/appkit-utils/src/ethers/EthersHelpersUtil.ts 96% 90.9% 100% 96% 54-55
Generated in workflow #7901 for commit 7efb1b9 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants