Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add eslint rule for boolean naming #3406

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

lukaisailovic
Copy link
Collaborator

@lukaisailovic lukaisailovic commented Dec 6, 2024

Description

Adding eslint rule to enforce boolean naming. Currently as a warning. Will change to error in due time.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • [] My changes generate no new warnings (THEY DO GENERATE LINT WARNINGS!)
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Dec 6, 2024

⚠️ No Changeset found

Latest commit: a3c5d1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 3:45pm
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 3:45pm
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 3:45pm
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 3:45pm

@lukaisailovic lukaisailovic changed the title chore: add eslint rule for bool naming chore: add eslint rule for boolean naming Dec 6, 2024
@lukaisailovic lukaisailovic requested a review from tomiir December 6, 2024 15:40
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 47.78% 12341 / 25826
🔵 Statements 47.78% 12341 / 25826
🔵 Functions 34.4% 838 / 2436
🔵 Branches 76.62% 1318 / 1720
File CoverageNo changed files found.
Generated in workflow #7920 for commit a3c5d1b by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants