Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: debug mode not working with universal provider #3429

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Dec 11, 2024

Description

Fixed a regression where debug mode wasn't working properly when universal provider was throwing an error. I also set debug mode to true by default.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1694

Showcase (Optional)

Screenshot 2024-12-11 at 09 32 37

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

linear bot commented Dec 11, 2024

Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: 8af2d9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-core Patch
@apps/builder Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 10:24am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 10:24am
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 10:24am
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 10:24am
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 10:24am

@magiziz magiziz changed the title fix: alert errors and debug mode not working fix: alert errors not working with universal provider Dec 11, 2024
@magiziz magiziz changed the title fix: alert errors not working with universal provider fix: universal provider debug mode not working Dec 11, 2024
@magiziz magiziz changed the title fix: universal provider debug mode not working fix: debug mode not working with universal provider Dec 11, 2024
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 52.79% 14462 / 27392
🔵 Statements 52.79% 14462 / 27392
🔵 Functions 39.86% 1034 / 2594
🔵 Branches 75.19% 1789 / 2379
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/adapters/solana/src/client.ts 37.46% 64.7% 34.61% 37.46% 60-67, 72-150, 160-163, 166-169, 172-173, 176-177, 180-181, 184-187, 194-195, 207-227, 230-263, 266-267, 270-271, 281-282, 288-294, 324-325, 354-356, 359-363, 369, 384-390, 397-400, 414-415, 421-425, 428-474
packages/appkit/src/client.ts 19.3% 100% 0% 19.3% 186-193, 196-197, 200-235, 239-241, 244-246, 249-250, 254-255, 258-259, 262-271, 274-277, 280-283, 286-287, 290-291, 294-295, 298-300, 303-304, 307-308, 311-313, 316-317, 320-321, 324-335, 338-347, 350-351, 354-355, 358-359, 362-363, 366-367, 370-371, 374-375, 378-379, 382-383, 386-387, 390-391, 394-395, 398-399, 402-403, 406-409, 614-615, 618-621, 624-625, 628-629, 632-633, 636-637, 640-641, 645-728, 731-742, 745-765, 768-774, 777-786, 789-1105, 1108-1109, 1112-1244, 1247-1273, 1276-1344, 1347-1356, 1359-1369, 1372-1450, 1453-1473, 1476-1487, 1490-1515, 1521-1542, 1545-1584, 1587-1630, 1633-1644, 1647-1659, 1662-1702, 1705-1706, 1709-1718, 1721-1738, 1741-1761, 1764-1773, 1776-1792, 1795-1845, 1848-1859, 1862-1872, 1875-1891
packages/core/src/controllers/OptionsController.ts 69.74% 83.33% 29.82% 69.74% 163, 168-169, 172-175, 186, 202, 206, 210, 214, 218, 222, 234, 238, 242, 246, 250, 254, 258, 266-269, 273-276, 280-283, 287-290
Generated in workflow #8033 for commit 8af2d9f by the Vitest Coverage Report Action

@magiziz magiziz merged commit 388e6d6 into main Dec 11, 2024
19 checks passed
@magiziz magiziz deleted the fix/alert-errors-not-working branch December 11, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants