Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: builder app theme initialize and go back #3434

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Dec 11, 2024

Description

  • Initialize the ThemeStore values when page loaded depending on the URL params
  • Hide go back button on header when in connect page and embedded mode enabled

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1700, APKT-1701
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: 71126d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@reown/appkit-scaffold-ui Patch
@apps/builder Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 2:01pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 2:01pm
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 2:01pm
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 2:01pm
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 2:01pm

@enesozturk enesozturk changed the title refactor/builder app theme initialize and go back refactor: builder app theme initialize and go back Dec 11, 2024
Copy link
Contributor

github-actions bot commented Dec 11, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 52.79% 14464 / 27394
🔵 Statements 52.79% 14464 / 27394
🔵 Functions 39.86% 1034 / 2594
🔵 Branches 75.19% 1789 / 2379
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/scaffold-ui/src/partials/w3m-header/index.ts 61.67% 36.36% 42.1% 61.67% 81, 120-125, 133-134, 142, 149-151, 154-161, 170-177, 188, 206, 221-228, 231-237, 244, 248-252, 255-260, 267, 271-279, 282-310, 313-314
Generated in workflow #8039 for commit 71126d1 by the Vitest Coverage Report Action

@enesozturk enesozturk merged commit 2a7a963 into main Dec 11, 2024
19 checks passed
@enesozturk enesozturk deleted the refactor/builder-app-theme-initialize-and-go-back branch December 11, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants