Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear siwx sessions on disconnect #3471

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

zoruka
Copy link
Contributor

@zoruka zoruka commented Dec 16, 2024

Description

Clear SIWX sessions when calling ConnectionController.disconnect

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1767
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 11:22pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 11:22pm
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 11:22pm
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 11:22pm
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 11:22pm

Copy link

linear bot commented Dec 16, 2024

Copy link
Contributor

github-actions bot commented Dec 16, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 53.95% 14822 / 27472
🔵 Statements 53.95% 14822 / 27472
🔵 Functions 40.88% 1067 / 2610
🔵 Branches 75.39% 1891 / 2508
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/core/src/controllers/ConnectionController.ts 59.87% 78.57% 32.65% 59.87% 88, 104-134, 152-153, 157-172, 176, 180, 184, 188, 192, 196, 200, 204, 208, 212, 234-235, 243, 247, 255-256, 108
packages/core/src/utils/SIWXUtil.ts 10.96% 66.66% 17.64% 10.96% 23-59, 62-137, 140-151, 154-162, 165-176, 179-270, 273-278, 284-285, 46-262
Generated in workflow #8149 for commit 376e198 by the Vitest Coverage Report Action

Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: 376e198

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@reown/appkit Patch
@reown/appkit-core Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants