-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adapter client improvements #3484
Open
magiziz
wants to merge
29
commits into
main
Choose a base branch
from
chore/adapter-improvement
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
cf1e0b1
chore: adapter improvement
magiziz 995ee1e
chore: create universal provider and auth provider after adapter crea…
magiziz 90aa105
chore: remove provider creation on adapter level
magiziz 0a6286c
fix: merge conflicts
magiziz 1c748ee
chore: remove code from bitcoin adapter to prevent build issues for now
magiziz 5b941a9
chore: await controllers
magiziz 59c1480
revert: edit bitcoin adapter
magiziz 9f00cd5
chore: migrate logic on chain blueprint level instead of adapter level
magiziz 8779eee
chore: tweak wagmi code
magiziz 2f89a13
chore: add comment for visibility
magiziz 17ece78
chore: tweak comment
magiziz 6c18680
revert: add setAuthProvider and setUniversalProvider undefined
magiziz a7901d4
chore: add mapToSIWX to AppKitSIWEClient
magiziz cfed5ba
chore: adding test for wagmi adapter
magiziz b709fb0
chore: add async operation for chain adapters
magiziz 38f5768
chore: add tests
magiziz 3493bc4
fix: merge conflicts
magiziz 4fe8143
chore: tweak
magiziz c108ef3
chore: fix ci errors
magiziz 0a8c9b0
chore: remove unused Connector type
magiziz e9524be
chore: check if auth provider exists
magiziz 3152e62
chore: only fetch provider from auth connector
magiziz 5dd7107
chore: fixes
magiziz 2068b3c
chore: listen for sync connectors only
magiziz dd62ee4
revert: remove reconnect logic for wagmi during siwx login
magiziz 7cfba60
chore: remove unused code
magiziz 847cf4f
chore: mock connectors
magiziz c7dda55
Merge branch 'main' of github.com:reown-com/appkit into chore/adapter…
tomiir 86ae60e
chore: prettier
magiziz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
export { AdapterBlueprint } from './ChainAdapterBlueprint.js' | ||
export type { ChainAdapterConnector } from './ChainAdapterConnector.js' |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens if multiple adapters emit this at the same time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine since we already filter them here and it ConnectorController as well.