Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only show browser tab option for browser wallets #3491

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Dec 17, 2024

Description

Some wallets don't support browser wallets, but we still show browser tab option for alll wallets. Instead we should only show browser tab option for browser wallets.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1794

Showcase (Optional)

image

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

linear bot commented Dec 17, 2024

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 7:39pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview Dec 17, 2024 7:39pm
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 7:39pm
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 7:39pm
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 7:39pm

Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: b0073a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@reown/appkit-scaffold-ui Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@magiziz magiziz changed the title fix: showing browser wallet option for all wallets fix: only show browser tab option for browser wallets Dec 17, 2024
@magiziz magiziz requested review from tomiir and zoruka December 17, 2024 19:03
Copy link
Contributor

github-actions bot commented Dec 17, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 54.8% 15125 / 27596
🔵 Statements 54.8% 15125 / 27596
🔵 Functions 41.9% 1100 / 2625
🔵 Branches 75.17% 1987 / 2643
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/scaffold-ui/src/views/w3m-connecting-wc-view/index.ts 67.09% 63.63% 66.66% 67.09% 44-45, 52, 62-63, 75-88, 95-96, 99-100, 121-122, 136-137, 145-146, 157, 161-164, 169, 173, 190, 194-208
Generated in workflow #8201 for commit b0073a1 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants