Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: serialize name and icon for wallet info #3493

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Dec 17, 2024

Description

  • Fix issue where wallet info was not properly serialized

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

Closes APKT-1446

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

linear bot commented Dec 17, 2024

Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: 958f1f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@reown/appkit Patch
@reown/appkit-core Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 10:30pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 10:30pm
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 10:30pm
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 10:30pm
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 10:30pm

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 53.98% 14897 / 27596
🔵 Statements 53.98% 14897 / 27596
🔵 Functions 41% 1076 / 2624
🔵 Branches 75.2% 1908 / 2537
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/adapters/ethers/src/client.ts 45.37% 51.78% 54.54% 45.37% 39-97, 113-114, 145-146, 159-182, 185-195, 208-244, 249-250, 257-274, 279-296, 299-320, 323-328, 338-339, 346-350, 373-380, 383-410, 414-415, 428-429, 431, 453-454, 458, 472, 483-485, 488-493, 496-500, 514-520, 542-544, 549-550, 552-557, 567-585, 591-592, 596-601, 610-611, 622-623
packages/adapters/ethers5/src/client.ts 43% 54% 54.54% 43% 40-98, 114-115, 146-147, 160-183, 186-196, 209-245, 250-251, 258-275, 280-297, 300-321, 324-329, 339-340, 347-351, 374-401, 404-411, 415-416, 429-430, 432, 457-458, 462, 476, 487-489, 492-497, 500-504, 518-524, 537-559, 567-585, 591-592, 596-601, 610-611, 622-623
packages/appkit/src/client.ts 18.85% 100% 0% 18.85% 196-203, 206-207, 210-246, 250-255, 258-260, 263-264, 268-269, 272-273, 276-285, 288-291, 294-297, 300-301, 304-305, 308-309, 312-314, 317-318, 321-322, 325-327, 330-331, 334-335, 338-349, 352-361, 364-365, 368-369, 372-373, 376-377, 380-381, 384-385, 388-389, 392-393, 396-397, 400-401, 404-405, 408-409, 412-413, 416-417, 420-423, 628-629, 632-635, 638-639, 642-643, 646-647, 650-651, 654-655, 658-662, 666-753, 756-767, 770-790, 793-799, 802-811, 814-1146, 1149-1150, 1153-1285, 1288-1328, 1331-1399, 1402-1411, 1414-1424, 1427-1505, 1508-1528, 1531-1542, 1545-1570, 1576-1597, 1600-1637, 1640-1683, 1686-1697, 1700-1712, 1715-1755, 1758-1759, 1762-1771, 1774-1791, 1794-1816, 1819-1828, 1831-1847, 1850-1900, 1903-1914, 1917-1927, 1930-1946
packages/core/src/controllers/ConnectorController.ts 78.8% 92.85% 82.6% 78.8% 94-95, 110-111, 121-129, 186-207, 46-74
Generated in workflow #8207 for commit 958f1f9 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant