Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokio-console subscriber configuration #2323

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Tokio-console subscriber configuration #2323

merged 1 commit into from
Nov 20, 2024

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Nov 19, 2024

Adds a configuration key in common to configure tokio-console subscriber bind address (support unix-sockets btw). Moreover, this lets tokio-console subscriber bind on all interfaces by default to make it easy to introspect restate-server running in docker containers.

Stack created with Sapling. Best reviewed with ReviewStack.

Copy link

github-actions bot commented Nov 19, 2024

Test Results

  7 files  ±0    7 suites  ±0   4m 22s ⏱️ +2s
 47 tests ±0   46 ✅ ±0  1 💤 ±0  0 ❌ ±0 
182 runs  ±0  179 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit b847c55. ± Comparison against base commit b82d591.

♻️ This comment has been updated with latest results.

@AhmedSoliman AhmedSoliman removed the request for review from tillrohrmann November 20, 2024 14:23
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the bind port of the tokio console subscriber configurable @AhmedSoliman. The changes look good to me. A few tests seem to fail now because tokio console cannot bind to the specified port. Probably we need to assign a random port or a random unix domain socket here

pub fn with_random_ports(self) {
self.base_config.admin.bind_address =
random_socket_address().expect("to find a random port for the admin server");
self.base_config.admin.query_engine.pgsql_bind_address =
random_socket_address().expect("to find a random port for the pgsql server");
self.base_config.ingress.bind_address =
random_socket_address().expect("to find a random port for the ingress server");
}
.

Copy link
Contributor

@muhamadazmy muhamadazmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thank you for this PR

Adds a configuration key in common to configure tokio-console subscriber bind address (support unix-sockets btw). Moreover, this lets tokio-console subscriber bind on all interfaces by default to make it easy to introspect restate-server running in docker containers.
@AhmedSoliman AhmedSoliman merged commit b847c55 into main Nov 20, 2024
23 checks passed
@AhmedSoliman AhmedSoliman deleted the pr2323 branch November 20, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants