-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tokio-console subscriber configuration #2323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the bind port of the tokio console subscriber configurable @AhmedSoliman. The changes look good to me. A few tests seem to fail now because tokio console cannot bind to the specified port. Probably we need to assign a random port or a random unix domain socket here
restate/crates/local-cluster-runner/src/node/mod.rs
Lines 61 to 68 in 2ec5491
pub fn with_random_ports(self) { | |
self.base_config.admin.bind_address = | |
random_socket_address().expect("to find a random port for the admin server"); | |
self.base_config.admin.query_engine.pgsql_bind_address = | |
random_socket_address().expect("to find a random port for the pgsql server"); | |
self.base_config.ingress.bind_address = | |
random_socket_address().expect("to find a random port for the ingress server"); | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Thank you for this PR
Adds a configuration key in common to configure tokio-console subscriber bind address (support unix-sockets btw). Moreover, this lets tokio-console subscriber bind on all interfaces by default to make it easy to introspect restate-server running in docker containers.
Adds a configuration key in common to configure tokio-console subscriber bind address (support unix-sockets btw). Moreover, this lets tokio-console subscriber bind on all interfaces by default to make it easy to introspect restate-server running in docker containers.
Stack created with Sapling. Best reviewed with ReviewStack.