Use range loops instead of iterator when possible #3862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpugin
commented
Nov 18, 2024
|
It's b0rken... Something about parts of C++20 not supported on some compilers? |
|
Range loops are supported since C++11. |
|
Oh, sorry -- wrong PR. Supposed to be #3852. However, now that you mention it, the failure seems to have something to do with ranges, Ubuntu, and clang. https://github.com/rism-digital/verovio/actions/runs/11954325075/job/33324173143#step:6:269 |
|
Yes, something was broken. Not sure what exactly, so I just avoided using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No change expected since this is only about simplifying code syntax.