Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug crash on Android 15 (with 16KB page size support) #331

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vegeta2102
Copy link

Description

Following on this issue #329 and the guidance from AndroidDeveloper
https://developer.android.com/guide/practices/page-sizes#compile-r26-lower
native-code has to rebuilt in order to be compatible with Android 15.

target_link_options(${CMAKE_PROJECT_NAME} PRIVATE "-Wl,-z,max-page-size=16384")

Updated CMakeLists.txt to enable 16 KB ELF alignment.

@vegeta2102
Copy link
Author

@umberto-sonnino
Can you have a look at it?

@georgmay
Copy link

georgmay commented Aug 19, 2024

Сan somebody please look into this issue? Rive is crashing on any non-potato droid.

@ErikUggeldahl ErikUggeldahl self-assigned this Nov 7, 2024
@ErikUggeldahl
Copy link
Contributor

Hi all. I'm the Android DevRel for Rive and am actively looking into this issue. The solution posed in this PR may not be sufficient, as it only affects our C++ files but not the associated libc++_shared.so. So we're now investigating bumping the NDK version which would ensure everything is 16kb aligned. Stay tuned for more as we test this solution more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants