Skip to content

Commit

Permalink
new arithmetic data converter that uses a viewmodel as input
Browse files Browse the repository at this point in the history 
Previously, arithmetic operation converters only supported const numbers as their input.
This PR adds support for arithmetic operations to use a view model value as their input, so we can chain operation where multiple data bound values are involved.
Added some comments on the relevant parts of the PR
This doesn't have the final texts, I'll update them after discussing it with the rest of the team

https://github.com/user-attachments/assets/32e3bd35-bdb3-4e25-93f8-6c11a3c69f11

Diffs=
6804948c90 new arithmetic data converter that uses a viewmodel as input (#8536)
  • Loading branch information
bodymovin committed Nov 11, 2024
1 parent 0ae0944 commit d1fad45
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .rive_head
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
532ca5dfb301f8ccc8a22176fbe722d8cda326e6
6804948c904238aa9c3f645d42f23c81a425f417
2 changes: 1 addition & 1 deletion submodules/rive-runtime
Submodule rive-runtime updated 24 files
+1 −1 .rive_head
+1 −10 dev/defs/data_bind/converters/data_converter_operation.json
+19 −0 dev/defs/data_bind/converters/data_converter_operation_value.json
+21 −0 dev/defs/data_bind/converters/data_converter_operation_viewmodel.json
+1 −1 dev/defs/data_bind/converters/data_converter_system_degs_to_rads.json
+1 −1 dev/defs/data_bind/converters/data_converter_system_normalizer.json
+1 −0 include/rive/data_bind/converters/data_converter_group.hpp
+4 −2 include/rive/data_bind/converters/data_converter_operation.hpp
+15 −0 include/rive/data_bind/converters/data_converter_operation_value.hpp
+29 −0 include/rive/data_bind/converters/data_converter_operation_viewmodel.hpp
+6 −0 include/rive/data_bind/data_bind_context.hpp
+14 −7 include/rive/generated/core_registry.hpp
+1 −20 include/rive/generated/data_bind/converters/data_converter_operation_base.hpp
+72 −0 include/rive/generated/data_bind/converters/data_converter_operation_value_base.hpp
+63 −0 include/rive/generated/data_bind/converters/data_converter_operation_viewmodel_base.hpp
+4 −3 include/rive/generated/data_bind/converters/data_converter_system_degs_to_rads_base.hpp
+4 −3 include/rive/generated/data_bind/converters/data_converter_system_normalizer_base.hpp
+1 −38 src/data_bind/context/context_value.cpp
+5 −5 src/data_bind/converters/data_converter_operation.cpp
+17 −0 src/data_bind/converters/data_converter_operation_value.cpp
+62 −0 src/data_bind/converters/data_converter_operation_viewmodel.cpp
+36 −0 src/data_bind/data_bind_context.cpp
+11 −0 src/generated/data_bind/converters/data_converter_operation_value_base.cpp
+11 −0 src/generated/data_bind/converters/data_converter_operation_viewmodel_base.cpp

0 comments on commit d1fad45

Please sign in to comment.