fix: dispose controller state on view drop

rive-app · Oct 3, 2023 · df31494 · df31494
1 parent b31ea17
commit df31494
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/android/src/main/java/com/rivereactnative/RiveReactNativeView.kt b/android/src/main/java/com/rivereactnative/RiveReactNativeView.kt
@@ -114,6 +114,12 @@ class RiveReactNativeView(private val context: ThemedReactContext) : FrameLayout
     addView(riveAnimationView)
   }
 
+  @OptIn(ControllerStateManagement::class)
+  fun dispose() {
+    removeView(riveAnimationView)
+    controllerState?.dispose();
+  }
+
   @OptIn(ControllerStateManagement::class)
   override fun onAttachedToWindow() {
     // The below solves: https://github.com/rive-app/rive-react-native/issues/198

diff --git a/android/src/main/java/com/rivereactnative/RiveReactNativeViewManager.kt b/android/src/main/java/com/rivereactnative/RiveReactNativeViewManager.kt
@@ -1,6 +1,5 @@
 package com.rivereactnative
 
-import android.util.Log
 import com.facebook.react.bridge.ReadableArray
 import com.facebook.react.common.MapBuilder
 import com.facebook.react.uimanager.SimpleViewManager
@@ -115,6 +114,11 @@ class RiveReactNativeViewManager : SimpleViewManager<RiveReactNativeView>() {
     return RiveReactNativeView(reactContext)
   }
 
+  override fun onDropViewInstance(view: RiveReactNativeView) {
+    view.dispose();
+    super.onDropViewInstance(view)
+  }
+
   override fun onAfterUpdateTransaction(view: RiveReactNativeView) {
     super.onAfterUpdateTransaction(view)
     view.update()