Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump iOS and Android deps to fix newline issue with text runs #202

Closed
wants to merge 2 commits into from
Closed

chore: bump iOS and Android deps to fix newline issue with text runs #202

wants to merge 2 commits into from

Conversation

zplata
Copy link
Contributor

@zplata zplata commented Sep 13, 2023

No description provided.

@zplata zplata requested a review from HayesGordon September 13, 2023 20:38
HayesGordon
HayesGordon approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@HayesGordon HayesGordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! We just need to bump the version in package.json - unless that's a separate PR. Probably should be a minor bump as this introduces the Rive renderer on iOS (disabled).

@zplata
Copy link
Contributor Author

zplata commented Sep 14, 2023

@HayesGordon ah good catch, forgot about that!
new commit here: 0aa2d6c

@zplata
Copy link
Contributor Author

zplata commented Sep 21, 2023

Closing this since Rive Events bump will encompass these changes, and be bumped a minor version

@zplata zplata closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HayesGordon HayesGordon HayesGordon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zplata @HayesGordon