fix nil safety in RiveReactNativeView.swift #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was able to consistently crash my React Native app when Hot Module Reloading was triggered. Removing the implicit optional unwrapping and making that explicit within RiveReactNativeView fixed the crashes I was running into.
|
Hi @ckknight thank you for the contribution! I'll get this reviewed soon |
|
Hi @ckknight, could you share a small repro that demonstrates the crash. I've not been able to reproduce the issue my side. Thank you in advance for the time spent on this! |
|
@HayesGordon Currently seeing this when calling play/pause imperative methods on a react ref passed to a rive instance from an effect. The problem is more reliable if you use a layout effect, which makes sense given it's synchronous. |
HayesGordon
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to consistently crash my React Native app when Hot Module Reloading was triggered. Removing the implicit optional unwrapping and making that explicit within RiveReactNativeView fixed the crashes I was running into.