fix: lifecycle and refcount issue when navigating pages #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zplata
approved these changes
Dec 22, 2023
| } | ||
|
|
||
| override fun createObserver(): LifecycleObserver { | ||
| dependencies = listOfNotNull(controller, rendererAttributes.assetLoader) |
There was a problem hiding this comment.
Ah ok - so the todo is basically to hook into one source of truth for these dependencies, rather than copying what RiveAnimationView does here, is that right?
There was a problem hiding this comment.
Exactly! Once RN uses the latest Android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212
TODO:
This is hotfix. A solution needs to be investigated to keep ReactNative and Android in sync for future changes.