-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rive-ios to v6.2, rive-android to 9.9.5, and remove iOS Skia support #270
Conversation
chore: bring back Skia for Android chore: bump to version 8 chore: remove packed tgzs
b7e41c1
to
1a853ba
Compare
Awesome, @lancesnider. We should bump Android as well. Due to recent changes, I think some native code will also need to be updated. I can do that, or if you're interested, we can hop on a call, and I'll show you. |
@HayesGordon Yes, please! |
CONTRIBUTING.md
Outdated
@@ -107,7 +107,7 @@ When an underlying runtime like [rive-ios](https://github.com/rive-app/rive-ios) | |||
Before running `yarn` at the root level of the project, set the appropriate version of the iOS runtime in `rive-react-native.podspec` at the root of the folder: | |||
|
|||
``` | |||
s.dependency "RiveRuntime", "5.1.6" | |||
s.dependency "RiveRuntime", "6.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now have v6.2.1 which fixes some potentials for crashes on iOS, might want to bump the bump!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Added the newer version. I also make this section of the docs generic (x.x.x
) so we don't have to keep updating it every time.
@@ -47,6 +47,9 @@ npm-debug.log | |||
yarn-debug.log | |||
yarn-error.log | |||
|
|||
# Ignore files generated by npm pack | |||
/*.tgz | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not totally related to this PR, but I use npm pack
a lot to test this package in other repos and I don't want to accidentally commit the .tgz.
@@ -107,7 +107,7 @@ When an underlying runtime like [rive-ios](https://github.com/rive-app/rive-ios) | |||
Before running `yarn` at the root level of the project, set the appropriate version of the iOS runtime in `rive-react-native.podspec` at the root of the folder: | |||
|
|||
``` | |||
s.dependency "RiveRuntime", "5.1.6" | |||
s.dependency "RiveRuntime", "x.x.x" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for getting this in!
Breaking change: rive-react-native no longer supports the Skia renderer for iOS.
Testing Examples:
yarn bootstrap
yarn example start
i
to start an iOS simulatorYou might have an issue where Expo tries to run on a previously used device, rather than a Simulator. If that happens, run
yarn example ios --simulator="iPhone 15"
(or whatever device).Testing with a new Expo project:
rive-react-native
runnpm pack
which will createrive-react-native-8.0.0.tgz
Podfile
set the minimum platform to 14:platform :ios, podfile_properties['ios.deploymentTarget'] || '14.0'
"rive-react-native": "file:../rive-react-native/rive-react-native-8.0.0.tgz"
(adjust the path if needed) and runnpm i
index.tsx
and runnpm run start
: