Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rive-ios to v6.2, rive-android to 9.9.5, and remove iOS Skia support #270

Merged
merged 7 commits into from
Oct 29, 2024

Conversation

lancesnider
Copy link
Contributor

@lancesnider lancesnider commented Oct 21, 2024

Breaking change: rive-react-native no longer supports the Skia renderer for iOS.

Testing Examples:

  1. Run yarn bootstrap
  2. Run yarn example start
  3. When Expo is ready, click i to start an iOS simulator

You might have an issue where Expo tries to run on a previously used device, rather than a Simulator. If that happens, run yarn example ios --simulator="iPhone 15" (or whatever device).

Testing with a new Expo project:

  1. In rive-react-native run npm pack which will create rive-react-native-8.0.0.tgz
  2. Create a new expo project and prebuild (formerly eject) it: https://docs.expo.dev/
  3. In Podfile set the minimum platform to 14: platform :ios, podfile_properties['ios.deploymentTarget'] || '14.0'
  4. Add this to your package.json dependencies: "rive-react-native": "file:../rive-react-native/rive-react-native-8.0.0.tgz" (adjust the path if needed) and run npm i
  5. Add a Rive component index.tsx and run npm run start:
import Rive, { Alignment, Fit, RiveRef } from 'rive-react-native'
...
<Rive
    url='https://cdn.rive.app/animations/vehicles.riv'
    fit={Fit.Contain}
    alignment={Alignment.Center}
    artboardName={'Truck'}
    style={{ width: 200, height: 200 }}
    autoplay={true}
  />

chore: bring back Skia for Android

chore: bump to version 8

chore: remove packed tgzs
@HayesGordon
Copy link
Contributor

Awesome, @lancesnider. We should bump Android as well. Due to recent changes, I think some native code will also need to be updated. I can do that, or if you're interested, we can hop on a call, and I'll show you.

@lancesnider
Copy link
Contributor Author

Awesome, @lancesnider. We should bump Android as well. Due to recent changes, I think some native code will also need to be updated. I can do that, or if you're interested, we can hop on a call, and I'll show you.

@HayesGordon Yes, please!

CONTRIBUTING.md Outdated
@@ -107,7 +107,7 @@ When an underlying runtime like [rive-ios](https://github.com/rive-app/rive-ios)
Before running `yarn` at the root level of the project, set the appropriate version of the iOS runtime in `rive-react-native.podspec` at the root of the folder:

```
s.dependency "RiveRuntime", "5.1.6"
s.dependency "RiveRuntime", "6.2.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now have v6.2.1 which fixes some potentials for crashes on iOS, might want to bump the bump!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Added the newer version. I also make this section of the docs generic (x.x.x) so we don't have to keep updating it every time.

@lancesnider lancesnider changed the title Bump rive-ios to v6.2 and remove iOS Skia support Bump rive-ios to v6.2, rive-android to 9.9.5, and remove iOS Skia support Oct 24, 2024
@@ -47,6 +47,9 @@ npm-debug.log
yarn-debug.log
yarn-error.log

# Ignore files generated by npm pack
/*.tgz

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not totally related to this PR, but I use npm pack a lot to test this package in other repos and I don't want to accidentally commit the .tgz.

@@ -107,7 +107,7 @@ When an underlying runtime like [rive-ios](https://github.com/rive-app/rive-ios)
Before running `yarn` at the root level of the project, set the appropriate version of the iOS runtime in `rive-react-native.podspec` at the root of the folder:

```
s.dependency "RiveRuntime", "5.1.6"
s.dependency "RiveRuntime", "x.x.x"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Contributor

@HayesGordon HayesGordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for getting this in!

@lancesnider lancesnider merged commit ba12e7a into main Oct 29, 2024
1 check passed
@lancesnider lancesnider deleted the chore-rive-ios-6-2 branch October 29, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants