-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OOB Asset Support #278
base: main
Are you sure you want to change the base?
OOB Asset Support #278
Conversation
the riv files and much of the code was taken from this branch/commit: rive-app/rive-react-native@main...bump-ios-android-oob
also improve documentation and example for asset file name
I've updated my branch with support for font assets on iOS. I've also updated the docs to explain the platform differences between asset names on iOS and Android. I've also updated the example to work cross platform |
Hi @Traviskn, this is great thanks for the contribution. I have a local version of out of band assets support that expands on what Zach did in the above mentioned branch. It also allows for assets to be loaded in using I'd need to clean up the initial draft and can tag you to review that - I'll aim for next week. Would love to get your, and others, input on which approach is best. |
@HayesGordon that sounds great, I’ll look forward to seeing your PR! Passing in the asset reference via require sounds like a great api |
@HayesGordon will your API be similar to the one for web? I finally found on discord a discussion of how to reload assets after the initial load by maintaining a reference to the asset object in the callback. I've tested here: Ideally we could do the same in ReactNative? |
This adds support for out of band assets as requested in #236 and #271.
The example rive file and assets as well as most of the iOS implementation code are from this branch by @zplata https://github.com/rive-app/rive-react-native/tree/bump-ios-android-oob
A few quirks are:
I would love feedback, I will see about adding font asset support to the iOS implementation as well