Refactor StateMachineInputs as DependencyObjects #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csmartdalton
force-pushed
the
contentattributes
branch
from
84daac7 to
8bca39f
Compare
duncandoit
approved these changes
Aug 4, 2022
csmartdalton
force-pushed
the
contentattributes
branch
2 times, most recently
from
88910e0 to
b6f1495
Compare
csmartdalton
commented
Aug 5, 2022
State machine inputs are not UI elements to layout, so we should use [ContentAttribute] instead to implement them as light-weight DependencyObjects.
csmartdalton
force-pushed
the
contentattributes
branch
from
b6f1495 to
efec6a0
Compare
|
Looks like all the feedback is addressed, except the properties stuff. I'll put that together in a new PR and go forward with landing this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State machine inputs are not UI elements to layout, so we should use
[ContentAttribute] instead to implement them as light-weight
DependencyObjects.