Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function widget unintended shortcut activation. #3389

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

karliss
Copy link
Member

@karliss karliss commented Oct 28, 2024

Happens when typing in filter. Only observed using Qt5 Appimage builds.

Your checklist for this pull request

Detailed description

Test plan (required)

  • !IMPORTANT! Test using the QT5 and QT6 appimage builds from CI
  • open any executable
  • select function in function widget
  • press N and observe rename window activating, test the X and ';' shortcuts as well
  • select filter area
  • type NX; -> the text should be written in input field without activating any of shortcuts

Closing issues

I thought there were a couple of similar issues, but I couldn't find them right now. If anyone remembers let me know.

Resolves some but not all cases of #3388

Happens when typing in filter. Only observed using Qt5 Appimage builds.
@karliss karliss marked this pull request as ready for review October 28, 2024 09:18
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described. Tested with the Qt 6 on Windows:

Version 2.4.0-HEAD-b0eef2a
Using rizin 0.8.0 @ windows-x86-64 commit: b96f355cfe48562276e0f6f441f1fe03a4ae8b33
Based on Qt 6.7.2 (MSVC 2017, 64 bit)

@karliss
Copy link
Member Author

karliss commented Nov 10, 2024

While doing last retest for the QT5 appimage found one more problematic shortcut but that one is created differently so for now will merge this fix and update the issue description with remaining problematic cases.

@karliss karliss merged commit f2692cb into rizinorg:dev Nov 10, 2024
14 checks passed
@karliss karliss deleted the function-shortcut branch November 10, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants