Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert zero-output EXPECT=<<EOF to single-line EXPECT= #4746

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Nov 27, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Like #4744, this pr converts zero-output EXPECT=<<EOF into single-line EXPECT= because:

  1. They take less lines and are faster to read.
  2. rz-test -i fixes zero-output stdout into single-line EXPECT=.

Conversion is done using:

(REGEX='EXPECT=<<EOF\nEOF' && grep -rPzl "$REGEX" test/db | xargs -n 1 perl -0777 -i -pe "s/$REGEX/EXPECT=/g")

Test plan

All builds are green.

Closing issues

...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant