Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate internal runtime state to Fiber storage #5176

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

rmosolgo
Copy link
Owner

@rmosolgo rmosolgo commented Nov 26, 2024

Trying out part of the suggestion from #5173

TODO:

  • See if tests pass. :__graphql_runtime_info was specially-handled before to not be inherited into new fibers.
  • Consider compat issues? This should all be internal
    • I searched google for :__graphql_runtime_info and didn't find anything outside of GraphQL-Ruby. I also checked GraphQL-Pro and GraphQL-Enterprise and didn't find any usages.

@rmosolgo rmosolgo added this to the 2.4.5 milestone Nov 26, 2024
@rmosolgo rmosolgo merged commit db1dba5 into master Nov 26, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant