-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates & Test Runner #117
Conversation
cpursley
commented
Feb 9, 2024
•
edited by robconery
Loading
edited by robconery
- Update libraries
- Deprecate Inflex (breaking!)
- Set up code quality & formatting checks
- Add mix tasks to setup test database
- Set up github test runner
Yay for a build! Thanks for setting that up! |
@robconery I guess 19th time is the charm... The main potential breaking change is the removal of the Inflex library. I was having a lot of difficulty getting it to compile reliably. Also, I don't love the opinionated approach about foreign key naming. Plus Inflex is another dependency and not a very complete or maintained one at that (in terms of number English words). Let me know what you think. Then maybe we could create a new mix release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for this - it looks like many of the changes are due to the syntax style guide, which is fine... I don't have much substantive feedback other than "yay"! If there's something in particular you want my thoughts on - let me know... otherwise... have at it!
You're welcome, thanks for the library. The main potential breaking change is removal of inflex. How do you feel about that? I've been chatting with the author of text about potentially adding a singularize function. So if you think we should wait and add back that sort of functionality to prevent breaks, let me know. |
Eh. Let's break things :). |
Woot! @robconery do you mind cutting a new hex release for this? Or sharing access with me? |