fix(bug): allow "complex" filter with update statement #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue where the following query failed:
It seems like
Moebius.Query.update
was doing some re-arranging of parameters and placeholders but did not take into account thein
(or other compound constructs). I removed that code and tweaked the remaining code to appropriately start the parameter numbers at the (seemingly) correct value.The existing tests pass with some re-work. To ensure that my test assumptions were correct, I also added a couple of assertions to ensure the parameter list is in the correct order. While my changes do not adversely affect my code, I'm more than happy to consider a different approach if this is not sufficient.
Thanks for providing the library; it's proving extremely useful.