add suite of ipv6 formatting tests, related to #796 #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed the printf() because macos gets mad without including stdio and they don't need to be there anyway |
|
@p-l- @robertdavidgraham can this be merged? It fixes/adds tests for ipv4 and ipv6 address formatting They're currently passing so I don't expect them to cause any problems, but defer to your judgement |
p-l-
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split out the oddly named test function for address formatting (named for ipv6, but had only a single test case, for ipv4)
I did this when trying to track down #796
Unfortunately, I didn't find any issues .... if anyone wants to take a look, feel free. I think more information is needed to reproduce the behavior that is reported there