Allow to pass variables/arrays to manager options and not just scalar…

… values
robertfausk · Mar 30, 2021 · 160da02 · 160da02
1 parent 3ebdb9d
commit 160da02
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 1 deletion.
diff --git a/src/ServiceContainer/PantherConfiguration.php b/src/ServiceContainer/PantherConfiguration.php
@@ -92,7 +92,7 @@ public function addManagerOptionsNode(): ArrayNodeDefinition
                 "These are the options passed as third argument to PantherTestCaseTrait::createPantherClient client constructor."
             )
             ->ignoreExtraKeys()
-            ->scalarPrototype()
+            ->variablePrototype()
             ->end()
         ;
 

diff --git a/tests/Unit/PantherConfigurationTest.php b/tests/Unit/PantherConfigurationTest.php
@@ -74,6 +74,41 @@ public function test_processed_configuration(): void
         );
     }
 
+    public function test_processed_configuration_for_manager_options(): void
+    {
+        $this->assertProcessedConfigurationEquals(
+            [
+                [
+                    'manager_options' => [
+                        'connection_timeout_in_ms' => '5000',
+                        'request_timeout_in_ms' => '120000',
+                        'capabilities' => [
+                                'goog:chromeOptions' => [
+                                    'prefs' => [
+                                        'download.default_directory' => '/var/www/html/tests/files/Downloads',
+                                    ],
+                                ],
+                        ],
+                    ],
+                ],
+            ],
+            [
+                'manager_options' => [
+                    'connection_timeout_in_ms' => '5000',
+                    'request_timeout_in_ms' => '120000',
+                    'capabilities' => [
+                        'goog:chromeOptions' => [
+                            'prefs' => [
+                                'download.default_directory' => '/var/www/html/tests/files/Downloads',
+                            ],
+                        ],
+                    ],
+                ],
+            ],
+            'manager_options'
+        );
+    }
+
     protected function getConfiguration(): PantherConfiguration
     {
         return new PantherConfiguration();