fix: Separates sync/async error handlers and makes 3 simple calls sync

[gustavoloureirodosreis]

Description

This PR improves the error handling system in the HTTP API, as a first step to solve issue #569. The motivation is to provide better support for both synchronous and asynchronous endpoints while maintaining backwards compatibility. Key changes include:

Error Handling Improvements:

• Introduced handle_common_exceptions() for shared error-handling logic.
• Added with_sync_route_exceptions() for synchronous endpoints.
• Added with_async_route_exceptions() for asynchronous endpoints.
• Maintained with_route_exceptions() for backward compatibility.

Endpoint Adjustments:

Converted /info, /model/registry, and /device/stats to synchronous endpoints.

No new dependencies were introduced for this change.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

How has this change been tested, please provide a testcase or example of how you tested the change?

Testing was done using Docker to verify endpoint behavior:

Pre-change testing: Ensured the baseline functionality and error responses of all endpoints.
Post-change testing: Verified that the endpoints were still performing as they should.

Endpoints changed and tested:

/info (static version info)
/model/registry (in-memory model listing)
/device/stats (Docker stats via synchronous SDK)

Any specific deployment considerations

No changes in usability, usage, costs, or secrets were required. The inline documentation now reflects the synchronous or asynchronous nature of the handlers.

Docs

• Docs updated? What were the changes:

Updated to specify the new sync/async nature of endpoints.
Maintained backward compatibility documentation.

[CLAassistant]

All committers have signed the CLA.

[PawelPeczek-Roboflow]

Hello there, thanks for contribution - it is really appreciated.

This is a good refactor and the only comment I have is to push the improved error handlers into separate module, let's say inference/core/interfaces/http/handlers/errors.py

[PawelPeczek-Roboflow]

And could you also accept CLA - without that we cannot move forward

[PawelPeczek-Roboflow]

Hi there, since this comment is not applied, pushing to the next release

[PawelPeczek-Roboflow]

hello there - will you be willing to carry on with work around this PR?

[gustavoloureirodosreis]

No ᐧ

…

On Mon, Nov 25, 2024 at 1:39 PM Paweł Pęczek ***@***.***> wrote: hello there - will you be willing to carry on with work around this PR? — Reply to this email directly, view it on GitHub <#819 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4YVWZKCHDWZGOQHPZL2SL2CNHEXAVCNFSM6AAAAABR47CDZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJYGUYTCNRUGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Gustavo Loureiro dos Reis

[PawelPeczek-Roboflow]

ok, thanks for confirming