perf(config): minimize tbl_deep_extend
#442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
33% of how much? I like performance but I also like simplicity, not sure if I like this tradeoff. In particular because it's only called once. Render code is called often, so I'm more enclined towards performance there than here. |
This is a ~33% performance increase for `config.setup`
Iron-E
force-pushed
the
perf/minimize-deep-extend
branch
from
2810a0a to
8c78737
Compare
|
0.0976ms → 0.0562ms (taken from the average of two 100,000 iteration benchmarks on my machine just now). If you don't think it's worth we can close :) Edit: source for benchmark |
|
lol no that's definitely not worth. if it was in render code maybe because it's called constantly, but here no. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a ~33% performance increase to
config.setup.The diff will look better after #408 merges. For now, see 2810a0a for the real diff.