-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: local m
→ local groups
#446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iron-E
added
documentation
Improvements or additions to documentation
refactor
Misc. change in an existing component of barbar.nvim
labels
Apr 7, 2023
romgrk
reviewed
Apr 9, 2023
romgrk
reviewed
Apr 9, 2023
Iron-E
force-pushed
the
ref/groups-module-rename
branch
from
April 9, 2023 21:25
6a7b983
to
bc33c5a
Compare
Ok, I've revised the PR based on your feedback. Summary:
|
Iron-E
force-pushed
the
ref/groups-module-rename
branch
from
April 9, 2023 21:39
bc33c5a
to
2ae209a
Compare
Iron-E
force-pushed
the
ref/groups-module-rename
branch
3 times, most recently
from
April 10, 2023 04:00
de928aa
to
47366b7
Compare
Also creates a clear naming distinction between `group_clumps` and `groups`.
Iron-E
force-pushed
the
ref/groups-module-rename
branch
from
April 10, 2023 04:09
47366b7
to
49897ea
Compare
romgrk
reviewed
Apr 10, 2023
romgrk
reviewed
Apr 10, 2023
romgrk
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
refactor
Misc. change in an existing component of barbar.nvim
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a few advantages:
local m
→local groups
group_clumps
andgroup
:barbar.render.group
barbar.groups.item
barbar.render.group[]
barbar.groups
barbar.render.group_clump
barbar.render.group
@param
s in thegroups
modulebarbar.render.group[]
, butbarbar.render
actually depends onbarbar.groups
, so it would be cyclical in a traditional type checking systemfor i = x, y, -1
instead ofutils.list_reverse