Animations: pin/unpin & fix close/open #455
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
romgrk
commented
Apr 10, 2023
romgrk
commented
- Pin/unpin animation
- Fix close/open animation (not working again in certain cases)
romgrk
commented
Apr 10, 2023
|
@Iron-E The pin/unpin animation is complete & ready for review. I'm not sure if I'll fix the close/open in this PR, if you wanna review this we could merge it as is. |
romgrk
commented
Apr 11, 2023
| @@ -533,7 +678,7 @@ local HL = { | |||
| --- @return nil|string syntax | |||
| local function generate_tabline(bufnrs, refocus) | |||
| local layout = Layout.calculate() | |||
There was a problem hiding this comment.
Future perf optimization: we don't need to recalculate the layout on every update.
romgrk
commented
Apr 11, 2023
Comment on lines
758
to
759
| local filler = { { hl = HL.FILL, text = (' '):rep(layout.buffers.width) } } | ||
| content = Nodes.insert_many(filler, 0, content) |
There was a problem hiding this comment.
Perf: I think this can be removed now.
|
Seeing some bugs, I'll do more work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.