Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed action tutorials interfaces dependency #88

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 30, 2024

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks @ahcorde . I'll note that this should work fine going all the way back to Humble, so it should be safe to merge in regardless of the branching strategy on this repository.

@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 2, 2024

@bmagyar do you mind to take a quick look ?

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grand! Thank you for the extra note @clalancette

@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 2, 2024

I can't merge the PR, do you mind to merge it and release it ?

@bmagyar
Copy link
Member

bmagyar commented Sep 2, 2024

Give me a minute to fix the CI :)

@bmagyar bmagyar merged commit 96dd5f6 into ros-teleop:master Sep 2, 2024
4 of 5 checks passed
@bmagyar
Copy link
Member

bmagyar commented Sep 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants