Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove performance_test from rosdistro #42459

Closed
wants to merge 1 commit into from
Closed

Remove performance_test from rosdistro #42459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions foxy/distribution.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3884,21 +3884,6 @@ repositories:
url: https://github.com/ros-perception/perception_pcl.git
version: foxy-devel
status: maintained
performance_test:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @audrow mentioned please don't modify EOL distros. They do not have any builds running anymore and are more of just a snapshot of the old state for historical purposes. As being EOL we don't want to be maintaining them anymore.

doc:
type: git
url: https://gitlab.com/ApexAI/performance_test.git
version: 1.2.1
release:
tags:
release: release/foxy/{package}/{version}
url: https://github.com/ros2-gbp/performance_test-release.git
version: 1.2.1-1
source:
type: git
url: https://gitlab.com/ApexAI/performance_test.git
version: master
status: maintained
performance_test_fixture:
release:
tags:
Expand Down
15 changes: 0 additions & 15 deletions galactic/distribution.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3072,21 +3072,6 @@ repositories:
url: https://github.com/ros-perception/perception_pcl.git
version: foxy-devel
status: maintained
performance_test:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also EOL

doc:
type: git
url: https://gitlab.com/ApexAI/performance_test.git
version: 1.2.1
release:
tags:
release: release/galactic/{package}/{version}
url: https://github.com/ros2-gbp/performance_test-release.git
version: 1.2.1-1
source:
type: git
url: https://gitlab.com/ApexAI/performance_test.git
version: master
status: maintained
performance_test_fixture:
release:
tags:
Expand Down
15 changes: 0 additions & 15 deletions humble/distribution.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5941,21 +5941,6 @@ repositories:
url: https://github.com/ros-perception/perception_pcl.git
version: ros2
status: maintained
performance_test:
doc:
type: git
url: https://gitlab.com/ApexAI/performance_test.git
version: 1.2.1
release:
tags:
release: release/humble/{package}/{version}
url: https://github.com/ros2-gbp/performance_test-release.git
version: 1.2.1-1
source:
type: git
url: https://gitlab.com/ApexAI/performance_test.git
version: master
status: maintained
performance_test_fixture:
release:
tags:
Expand Down
15 changes: 0 additions & 15 deletions iron/distribution.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4506,21 +4506,6 @@ repositories:
url: https://github.com/ros-perception/perception_pcl.git
version: ros2
status: maintained
performance_test:
doc:
type: git
url: https://gitlab.com/ApexAI/performance_test.git
version: 1.2.1
release:
tags:
release: release/iron/{package}/{version}
url: https://github.com/ros2-gbp/performance_test-release.git
version: 1.2.1-4
source:
type: git
url: https://gitlab.com/ApexAI/performance_test.git
version: master
status: maintained
performance_test_fixture:
release:
tags:
Expand Down
15 changes: 0 additions & 15 deletions jazzy/distribution.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4722,21 +4722,6 @@ repositories:
url: https://github.com/ros-perception/perception_pcl.git
version: ros2
status: maintained
performance_test:
doc:
type: git
url: https://gitlab.com/ApexAI/performance_test.git
version: 1.2.1
release:
tags:
release: release/jazzy/{package}/{version}
url: https://github.com/ros2-gbp/performance_test-release.git
version: 2.0.0-2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version is failing because some module has flagged the rosdistro as unsupported. It seems that this should be resolvable potentially something has a hardcoded list of compatible versions.

https://build.ros2.org/job/Jbin_uN64__performance_test__ubuntu_noble_amd64__binary/115/console

00:01:55.303 CMake Error at CMakeLists.txt:500 (message):
00:01:55.303   Unsupported ROS_DISTRO
00:01:55.303 
00:01:55.303

source:
type: git
url: https://gitlab.com/ApexAI/performance_test.git
version: master
status: maintained
performance_test_fixture:
release:
tags:
Expand Down
15 changes: 0 additions & 15 deletions rolling/distribution.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4427,21 +4427,6 @@ repositories:
url: https://github.com/ros-perception/perception_pcl.git
version: ros2
status: maintained
performance_test:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the new release has fixed the builds in rolling: https://build.ros2.org/job/Rbin_uN64__performance_test__ubuntu_noble_amd64__binary/

So reverting rolling seems incorrect and it seems like you are very close to being able to build on the other platforms as it works in your CI and on the build farm.

doc:
type: git
url: https://gitlab.com/ApexAI/performance_test.git
version: 1.2.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version looks like it was pinned to a version but not updated with the new releases.

release:
tags:
release: release/rolling/{package}/{version}
url: https://github.com/ros2-gbp/performance_test-release.git
version: 2.0.0-1
source:
type: git
url: https://gitlab.com/ApexAI/performance_test.git
version: master
status: maintained
performance_test_fixture:
release:
tags:
Expand Down
Loading