Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve #600 (ExtrapolationException & its error_code) #601

Merged
merged 2 commits into from
May 8, 2023
Merged

Solve #600 (ExtrapolationException & its error_code) #601

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23de342
error_code shall follow same path of its error string
roncapat May 6, 2023
15a1595
Lint
roncapat May 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tf2/src/buffer_core.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,7 @@ tf2::TF2Error BufferCore::walkToTopParent(
uint32_t depth = 0;

TF2Error error_code = TF2Error::TF2_NO_ERROR;
TF2Error extrapolation_error_code = TF2Error::TF2_NO_ERROR;
std::string extrapolation_error_string;
bool extrapolation_might_have_occurred = false;

Expand All @@ -367,7 +368,9 @@ tf2::TF2Error BufferCore::walkToTopParent(
break;
}

CompactFrameID parent = f.gather(cache, time, &extrapolation_error_string, &error_code);
CompactFrameID parent = f.gather(
cache, time, &extrapolation_error_string,
&extrapolation_error_code);
if (parent == 0) {
// Just break out here... there may still be a path from source -> target
top_parent = frame;
Expand Down Expand Up @@ -458,7 +461,7 @@ tf2::TF2Error BufferCore::walkToTopParent(
lookupFrameString(source_id) << "] to frame [" << lookupFrameString(target_id) << "]";
*error_string = ss.str();
}
return error_code;
return extrapolation_error_code;
}
createConnectivityErrorString(source_id, target_id, error_string);
return tf2::TF2Error::TF2_CONNECTIVITY_ERROR;
Expand Down