-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types to Action with rhel roscli fix #1361
base: rolling
Are you sure you want to change the base?
Conversation
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
@fujitatomoya When you get a chance can you run rhel CI on this to see if the fix works? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@InvincibleRMC thank you very much for being patient and keep making contribution for this type checks. we really appreciate that!
I will start the CI now!
just out of curiosity, i would like to learn which part was failing the RHEL with previous PR. could you point out the source code and share your thoughts?
Pulls: #1361 |
I don't imagine the changes I made would cause the security failings in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@InvincibleRMC thanks for sharing, this looks good to me. and CI is green. but in this time, i would like to have 2nd review from other PMC members. please wait for a while.
@Mergifyio update |
✅ Branch has been successfully updated |
Pulls: #1361 |
@sloretz Do you need anything else from me? |
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Adds type to actions. A do over of #1349. I believe I have fixed the bug causing rhel roscli to fail.