Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Capybara/SpecificFinders when find with kind option #65

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

ydah
Copy link
Member

@ydah ydah commented Aug 28, 2023

Support the following cases:

find(:css, '#some-id')

Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with main (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

…kind option

Support the following cases:
```ruby
find(:css, '#some-id')
```
@ydah ydah merged commit 53accbc into main Sep 3, 2023
22 checks passed
@ydah ydah deleted the fix-specific-finders branch September 3, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant