Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install target mingw packages, no partial upgrade #38

Closed
wants to merge 1 commit into from
Closed

Install target mingw packages, no partial upgrade #38

wants to merge 1 commit into from

Conversation

deivid-rodriguez
Copy link
Contributor

A package change in msys2/MINGW-packages#19913 made this pacman command to start failing.

See for example https://github.com/rubygems/rubygems/actions/runs/7755580051/job/21151329683?pr=7422.

Upstream they recommended to run either -S (no upgrade) or -Syu (full upgrade).

I went with the former because it seems like a more deterministic thing to do.

@MSP-Greg
Copy link
Collaborator

MSP-Greg commented Feb 2, 2024

Thanks. Let me look into this...

@deivid-rodriguez
Copy link
Contributor Author

I probably messed something up when packaging in dist?

@MSP-Greg
Copy link
Collaborator

MSP-Greg commented Feb 2, 2024

@deivid-rodriguez

I probably messed something up when packaging in dist?

No, that isn't the issue. This is something that happened once before.

Can you check this now?

If a repo has no commits, GitHub Actions cron jobs stop running after some time interval that cannot be changed.

The MSYS2 archive files are created by https://github.com/ruby/setup-msys2-gcc, and the CI there stopped. I just reenabled them, and ran the CI.

I'm going to set more frequent reminders to check that, or maybe make a commit once every two weeks...

@deivid-rodriguez
Copy link
Contributor Author

Can you check this now?

What do I need to do? Force-push?

@MSP-Greg
Copy link
Collaborator

MSP-Greg commented Feb 2, 2024

@deivid-rodriguez

Sorry, nothing to do here. I'm checking whether this is fixed. CI Is running right now, added clang to a Puma run in my fork. It also uses this repo's action.

CI passed (installed clang), so your RubyGems workflows should be passing now. Also, no need for this PR.

@deivid-rodriguez deivid-rodriguez deleted the dont-upgrade branch February 2, 2024 16:11
@MSP-Greg
Copy link
Collaborator

MSP-Greg commented Feb 2, 2024

@deivid-rodriguez
Copy link
Contributor Author

Things were broken for us an hour ago, that's why I started troubleshooting this. Glad it's all good now.

@deivid-rodriguez
Copy link
Contributor Author

deivid-rodriguez commented Feb 2, 2024

It does seem better to me regardless to not upgrade anything under the hood unless not explicitly requested, even more knowing that this has indeed broken at some point and that https://github.com/msys2/MINGW-packages/ maintainers stated -Sy as "not supported" and likely to break with package renames like it happened here.

But this is totally up to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants