-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External Form Upload: Display import summary / errors #1208
base: main
Are you sure you want to change the base?
Conversation
@@ -13,6 +13,7 @@ def initialize(file) | |||
end | |||
|
|||
def call | |||
# Validate that file is in CSV format before we read from it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khiga8 Thanks for pointing this out! This started a discussion in our last meeting about other validations we should be checking for in this service. I opened PR #1211 which adds a file type validation and checks for the correct headers.
Hopefully I didn't step on your toes, but I figured the validations were outside the scope of this issues and didn't want to cause any confusion or add more work. If you have a better way to validate though I'd love to see it!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you :)
75f55ce
to
07378f3
Compare
🔗 Issue
#1112
✍️ Description
This PR displays import summary feedback when a file is uploaded through the external form upload.
role="alert"
on the heading of the dynamically injected content, so that assistive technology users, such as screen reader users, are made aware of this new content via announcement when it's added to the page.📷 Screenshots/Demos