Add timescaledb to infrastructure #4716
Conversation
docker-compose.yml
Outdated
| ports: | ||
| - "5432:5432" | ||
| timescale: | ||
| image: timescale/timescaledb-ha:pg16.2-ts2.14.2-all |
There was a problem hiding this comment.
This image is 1.5GB @jonatas, isn't there any small one suitable for development + CI?
There was a problem hiding this comment.
Yes, there's a smaller one but does not contains the toolkit. Probably latest-pg16 already do the work. < 300MB.
| image: timescale/timescaledb-ha:pg16.2-ts2.14.2-all | |
| image: timescale/timescaledb:latest-pg16 |
There was a problem hiding this comment.
Link 404s, https://hub.docker.com/layers/timescale/timescaledb/latest-pg16. What's the toolkit useful for?
There was a problem hiding this comment.
Toolkit can give extra flexibility in the components for statistics, containing several cool stuff like most of the hyperfunctions.
It allow us to use components like stats_agg that have some embeddings for several statistics, so you can extract stddev, average without recomputing everything. Percentile_agg do the same for distribution and allow you to get several discs without reprocessing. The coolest part is rollup that allows to merge this _agg objects and reuse pre-calculated data into bigger timeframes.
There was a problem hiding this comment.
I'm investigating if we have any light image that includes the toolkit, but we can also move without it and later just add it as a plus.
I updated it now and tested again 👍
simi
force-pushed
the
add-timescaledb-to-stack
branch
2 times, most recently
from
7b3f763
to
500297d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4716 +/- ##
==========================================
- Coverage 97.00% 97.00% -0.01%
==========================================
Files 397 406 +9
Lines 8428 8520 +92
==========================================
+ Hits 8176 8265 +89
- Misses 252 255 +3 ☔ View full report in Codecov by Sentry. |
simi
force-pushed
the
add-timescaledb-to-stack
branch
3 times, most recently
from
ecdb6da
to
e4289ae
Compare
jonatas
force-pushed
the
add-timescaledb-to-stack
branch
from
4d0a7b3
to
6cf98a4
Compare
|
After rebase github is showing the unrelated commits. Any thoughts how to fix it? |
I'll fix. |
simi
force-pushed
the
add-timescaledb-to-stack
branch
from
b2277fc
to
00fb0ee
Compare
|
@jonatas fixed |
|
Thanks a lot @simi! Anything else I can do from now? Happy to proceed with next PR 🤓 |
simi
force-pushed
the
add-timescaledb-to-stack
branch
from
00fb0ee
to
ca68070
Compare
It relates to the very beginning of #4642.
Talking to @simi, we agreed on adding a basic setup to infra and incrementally be adding the remaining features. Nothing new here, just a fragment of previous work.
The POC is also available for those that are curious on how it will work.