Fix locales that require a 'host' variable #5273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozovalihasan
force-pushed
the
fix-hosts-of-locales
branch
from
73b8898 to
d7ad697
Compare
|
Hi @colby-swandale, I would like to contribute this repo. Can you help me add a reviewer to this PR? |
|
@ozovalihasan hello, happy to review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5273 +/- ##
==========================================
- Coverage 96.88% 94.23% -2.65%
==========================================
Files 457 457
Lines 9576 9635 +59
==========================================
- Hits 9278 9080 -198
- Misses 298 555 +257 ☔ View full report in Codecov by Sentry. |
segiddins
approved these changes
Nov 26, 2024
|
We've seen the coverage check fail lately on outside contributor PRs, so that can be ignored. Ready to merge. |
martinemde
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5266 Some locales require a
hostvariable, which was missed during translation. So, these parts are fixed.I have only checked locales having a
hostvariable to avoid expanding the scope of this PR.