fix: 5.7.0 patch (#2) #3
Open
+9,486
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mieszko4
force-pushed
the
fix/notifee-foreground-service-crash
branch
from
aa861c0
to
760f006
Compare
2 tasks
Before running I had to: 1. Remove ` && (yarn tests_rn:ios:pod:install || true)` from yarn prepare 2. Change to openjdk@11
|
@mieszko4 is this PR ready to go? |
Yes, but we want to keep this PR open. |
|
Ah, I forgot. Sounds good. I've made that more clear in the description |
mzbyszynski
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE. WE KEEP THIS PR OPEN FOREVER.
Revisit this PR once we update to newer Notifee version.
List of fixes:
Checklist:
yarnthenyarn build:all(Already done in this PR (200d697)https://gitpkg.now.sh/rune/notifee/packages/react-native?COMMIT_HASHinpackage.json