-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] The Stronghold of Security #312
base: develop
Are you sure you want to change the base?
Conversation
Stronghold of Security plugins: Door plugin that handles travelling through the stronghold doors Reward plugin that handles receiving rewards Quiz plugin that handles the quiz questions and answers Objects plugin that handles interaction with objects in the dungeon (such as portals, ladders, escape ropes) NPC keys for all NPCs in the Stronghold. NPC Spawns for all of the NPCs in the Stronghold. Travel Locations for the various levels of the dungeon. Pit of Pestilence map data from Revision #455 to the cache, and xteas folder. Music tracks for the Stronghold levels Modify: Change facepalm emote name to Slap Head Dialogue plugin to give dialogues the ability to wrap into new ones if the text is more than 4 lines. waitForPathing() method with optional boolean to ignore interaction distance requirement. Fix: Player's music player button state not loading correctly upon login
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preliminary review, please use underscore_case
for config keys, anything with a prefix rs:
or x:
I still need to work on the books a bit more, definitely. Right now it's only really applied for one case. But I want to make it more generic so that any BookData object can take the methods and use them to display their info easily. |
A bug where books with long sections wouldn't display all pages. A typo in a mining message Add: A method to find BookData from book ID. Book data for the Construction guide book Book data for the pie recipe book Modify: The book system to load all books from the books directory The book system to be more generic, and much simpler in certain areas. Removed lots of unnecessary duplicate calls. Rename: stronghold-of-security-book.plugin to books.plugin loadStrongholdOfSecurityBook() to loadBookData()
This draft adds support for the Stronghold of Security.
Features of this change include:
Aspects not yet implemented are:
In addition to these changes, this commit also: