Use xml-exc-c14n Canonicalizer by default #204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SAML Specification states the following
right now, the Canonicalization used by default through the dsig library is another one (
C14N11
).Using the C14N11 does not work with every IDP, since some only support the recommendet Excl-C14N standard.
While the Canonicalization can be chosen through a param passed to the
SAMLServiceProvider
, it would be sensible to follow the spec by default, if no option is provided