Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xml-exc-c14n Canonicalizer by default #204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Stummi
Copy link

@Stummi Stummi commented Dec 5, 2024

The SAML Specification states the following

5.4.3 Canonicalization Method
SAML implementations SHOULD use Exclusive Canonicalization [Excl-C14N], with or without comments,
both in the <ds:CanonicalizationMethod> element of <ds:SignedInfo>, and as a
<ds:Transform> algorithm. Use of Exclusive Canonicalization ensures that signatures created over
SAML messages embedded in an XML context can be verified independent of that context.

right now, the Canonicalization used by default through the dsig library is another one ( C14N11).

Using the C14N11 does not work with every IDP, since some only support the recommendet Excl-C14N standard.

While the Canonicalization can be chosen through a param passed to the SAMLServiceProvider, it would be sensible to follow the spec by default, if no option is provided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant