Fix compatibility with Microsoft Active Directory Federation Services #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Microsoft's SAML implementation does not provide the NameID value within the assertion. gosaml2 did not handle this condition gracefully and prevented gosaml from working with Azure AD and AD FS. This patch fixes this and updates the README.md.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft's SAML implementation does not provide the NameID value within the assertion. This causes gosaml2 to not accept the assertion even though it's technically valid.
gosaml2 did not handle this condition gracefully and prevented gosaml2 from working with AD FS and AzureAD. This patch fixes this and updates the README.md to include these tested platforms.