feat: Add SmolStr::from_static
#62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
reviewed
Jan 2, 2024
README.md
Outdated
| @@ -7,13 +7,14 @@ | |||
|
|
|||
| A `SmolStr` is a string type that has the following properties: | |||
|
|
|||
| * `size_of::<SmolStr>() == 24 (therefore == size_of::<String>() on 64 bit platforms) | |||
| * `size_of::<SmolStr>() == 24` (therefor `== size_of::<String>()` on 64 bit platforms) | |||
There was a problem hiding this comment.
Suggested change
| * `size_of::<SmolStr>() == 24` (therefor `== size_of::<String>()` on 64 bit platforms) | |
| * `size_of::<SmolStr>() == 24` (therefore `== size_of::<String>()` on 64 bit platforms) |
lnicola
reviewed
Jan 2, 2024
README.md
Outdated
| * `Clone` is `O(1)` | ||
| * Strings are stack-allocated if they are: | ||
| * Up to 23 bytes long | ||
| * Longer than 23 bytes, but substrings of `WS` (see `src/lib.rs`). Such strings consist | ||
| solely of consecutive newlines, followed by consecutive spaces | ||
| * If a string does not satisfy the aforementioned conditions, it is heap-allocated | ||
| * Additionally, a `SmolStr` can be explicitely created from a `&'static str` without allocation |
There was a problem hiding this comment.
Suggested change
| * Additionally, a `SmolStr` can be explicitely created from a `&'static str` without allocation | |
| * Additionally, a `SmolStr` can be explicitly created from a `&'static str` without allocation |
lnicola
reviewed
Jan 2, 2024
src/lib.rs
Outdated
| @@ -78,6 +79,17 @@ impl SmolStr { | |||
| }) | |||
| } | |||
|
|
|||
| /// Constructs a `SmolStr` from a statically allocated buffer. | |||
There was a problem hiding this comment.
Suggested change
| /// Constructs a `SmolStr` from a statically allocated buffer. | |
| /// Constructs a `SmolStr` from a statically allocated string. |
lnicola
approved these changes
Jan 2, 2024
|
Thanks, should probably bump the version in the manifest too. |
Allows creating `SmolStr`s longer than 23 bytes in constant contexts. This is done by replacing the `Repr::Substring` variant by a more general `Repr::Static(&'static str)` variant, and borrowing from ̀`WS` directly instead of storing two `usize`s. As a bonus, it also simplifies the `as_str` implementation, hopefully saving an extra branch.
|
Thanks! Will make a release for this later, depending on whether other PRs will be merged or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows creating
SmolStrs longer than 23 bytes in constant contexts.This is done by replacing the
Repr::Substringvariant by a more generalRepr::Static(&'static str)variant, and borrowing from ̀WSdirectly instead of storing twousizes.As a bonus, it also simplifies the
as_strimplementation, hopefully saving an extra branch.