-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation of benchmarks #505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Note: there is another error on nightly that's still happening: Could this PR address this one too? Looks related |
It looks like that error is due to the use of an old version of rust nightly (which is needed for SIMD support) which Another way would be to switch to an RNG that doesn't require another dependency. Are any in |
Did you consider using https://docs.rs/rand/0.7.3/rand/rngs/struct.SmallRng.html for this? |
|
I think we can enable it for rand, yes. Presumably, other crates enabling |
This switches to `SmallRng` since that doesn't require adding another dependency.
Done. |
Thank you! let's just see what CI thinks :) |
SIMD is still broken - https://travis-ci.org/github/rustgd/cgmath/jobs/694761384#L220 |
That's a different one than the one that was broken by this PR (current nightly rather than nightly-2019-01-01), and it won't work until #490 is implemented. |
Yeah, I figured, hence this PR is merged :) |
This adds the
rand_isaac
dependency since that's no longer in therand
crate, but in the future we should consider switching to an RNG inrand
so we don't need another dependency.