Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did the first steps to remove the
Point
(solving issue #502)As result all the
PointN
structs were removed (and thepoint.rs
file was removed too) and replaced withVectorN
.VectorN
hadEucledeanSpace
implemented too. Some associated types and methods were removed for simplificationDiff
,Scalar
inEuclideanSpace
dot
,from_vec
andto_vec
forEucledeanSpace
to_homogenous
andfrom_homogenous
were added toVector3
for convenienveThe library seems to compile in my case. Most likely the change is too radical and depreacating should be considered instead
I wasn't sure about some methods in
Transform
, so I left them intact